Enhancing the import CSV function #130
Merged
Irtesaam merged 2 commits intoOpenVibes:mainfrom Aug 16, 2025
Merged
Conversation
Contributor
Author
|
@Irtesaam is this fine?? |
Contributor
Author
|
@Irtesaam can you review this PR |
Irtesaam
approved these changes
Aug 16, 2025
Collaborator
There was a problem hiding this comment.
@FireFistisDead The changes looks good but a couple of edge cases you should fix:
- Import via Quick Action menu throws
import error : Cannot read property 'length' of undefinedin some cases while the Settings import works fine. Likely you haven't updated the quick actions import function. - Subjects without slots import correctly, but their classroom isn’t being picked up if no slots are defined.
For now, I am approving and merging these changes as its not a breaking change, but please raise a follow-up issue to fix these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
It fixes the subjects without display will also be shown in the csv file and also while importing they are getting sucessfully imported
Closes #129
Description
This pull request introduces a comprehensive CSV import feature for schedules and subjects, allowing users to import data directly into the app from CSV files. It includes robust CSV parsing and validation, UI integration for importing, and enhancements to the export format. The changes span the UI, state management, CSV utilities, and Android file provider configuration.
CSV Import Functionality
csv-import.tsthat robustly parses, validates, and imports schedule/subject data from CSV files, handling both single and multiple register formats, unscheduled subjects, and time slot normalization. It provides user feedback and error handling throughout the process.pickCSVFileRawincsv-picker.tsto fetch raw CSV file content for import, supporting the new import workflow.UI Integration
SettingsScreen, with logic to trigger the CSV import process, validate, and add subjects to the active register, including error handling and user confirmation dialogs. [1] [2]CustomTabBarto support subject import via CSV, using the new utilities and providing error feedback.State Management
addMultipleCardsto efficiently add imported cards to a register, supporting bulk operations from CSV import. [1] [2]CSV Export Enhancement
csv-export.tsto include a section for subjects without scheduled time slots, making exports more informative and compatible with the new import logic. [1] [2] [3]Android File Provider Support
provider_paths.xmlto configure Android file provider paths, ensuring compatibility for file sharing and CSV import/export on Android devices.Files Changed
Screenshots/Videos
https://drive.google.com/file/d/1inc5w0eyp6GiSyTfKRI5BemWCFV1UXLL/view?usp=sharing
GSSoC Contributor
Testing Device